Avoid race b/w read/write shm_global_variable #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a function to write shm_global_variable address which is protected by the mutexes. Another function to read shm_global_variable with a thread local variable to make sure it read only once. This way we avoid the race happening between reading and writing of this shared global variable.
maxwellpirtle
requested changes
Aug 5, 2025
Comment on lines
+34
to
+36
| if (local_shm_start == NULL) { | ||
| local_shm_start = global_shm_start; | ||
| } |
Collaborator
There was a problem hiding this comment.
This needs to be wrapped in a pthread_mutex_lock()/pthread_mutex_unlock(), but otherwise it's good
Collaborator
There was a problem hiding this comment.
When I say this, I meant only line 35 to be precise since local_shm_start is thread_local.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function to write shm_global_variable address which is protected by the mutexes. Another function to read shm_global_variable with a thread local variable to make sure it read only once. This way we avoid the race happening between reading and writing of this shared global variable.