Skip to content

fix: reject trailing tokens in lucene parser #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mchurichi wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: reject trailing tokens in lucene parser #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8624020
fix: reject trailing tokens in lucene parser
mchurichi Mar 6, 2026
d47e2bd
test: correct lucene trailing token expectations
mchurichi Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/query/lucene.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ func Parse(queryStr string) (*Query, error) {
return nil, err
}

parser.skipWhitespace()
if parser.pos < len(parser.input) {
return nil, fmt.Errorf("unexpected token near %q", parser.input[parser.pos:])
}

return &Query{filters: []Filter{filter}}, nil
}

Expand Down
4 changes: 4 additions & 0 deletions pkg/query/lucene_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ func TestParse(t *testing.T) {
{"complex query", "(level:ERROR OR level:WARN) AND service:api", false},
{"wildcard field", "message:*timeout*", false},
{"quoted string", `message:"connection refused"`, false},
{"dangling closing parenthesis", `level:ERROR)`, true},
{"extra closing parenthesis after group", `(level:ERROR))`, true},
{"implicit AND with trailing keyword", `level:ERROR foo`, false},
{"implicit AND after grouped expression", `(level:ERROR) bar`, false},
}

for _, tt := range tests {
Expand Down
Loading