87 allsec is slow #88
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
hvangeffen
changed the title
ramcdougal
reviewed
Jan 29, 2024
| else | ||
| % Valid section: append. | ||
| all_sections{end+1} = neuron.Section(section, owner); | ||
| all_sections{end+1} = neuron.Section(section, owner, all_sections{1}.mech_list, all_sections{1}.range_list, true); |
Contributor
There was a problem hiding this comment.
I have no intuitiion for wy the new section object would be copying information from the 1st section?
Collaborator
Author
There was a problem hiding this comment.
Currently the reason allsec is slow is partly due to every section getting all neuron functions and splitting them into mech list and range list:
This PR adds two params to the Section constructor to pass these values if they should not be calculated again.
These values should not be persistent as these functions can dynamically change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.