Open
Conversation
Owner
|
I love the idea, but currently this introduces a new failure mode for long-lived clients if a DNS record they're sending metrics to rotates IPs, as is common in cloud providers like AWS. I think we probably need to either re-resolve the record on a NotConnected error, or provide a way for the client to be refreshed so users can do that on their own |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently perform name resolution on every metric that is sent.
This pull request moves name resolution into the
Optionsconstructor. One consequence of this change isOptions::newis now fallible, so this PR will introduce a breaking API change.