Open
Conversation
This allows people to write custom implementations of the Tag trait rather than having to rely on format! or similar and passing in tags as str/String. The Tag trait has a blanket implementation for AsRef<str> so this change should be backwards compatible.
Author
|
As is this doesn't let people create I could change it in a few ways
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows people to write custom implementations of the Tag trait
rather than having to rely on format! or similar and passing in tags as
str/String.
The Tag trait has a blanket implementation for AsRef so this change
should be backwards compatible.
I don't have any strong need to include TagTuple in the upstream library,
it's mostly just as an example usage. The primary purpose is just to be able
to have tags that don't rely on being formatted before being passed to this
library.