Skip to content

engine: improve universe composition efficiency#1979

Merged
mcallegari merged 1 commit intomasterfrom
unirework
Mar 17, 2026
Merged

engine: improve universe composition efficiency#1979
mcallegari merged 1 commit intomasterfrom
unirework

Conversation

@mcallegari
Copy link
Owner

  • Universe::tick() now releases the semaphore only if no pending token exists.
  • Elapsed-time aware fading: improves fade timing accuracy under variable CPU load and scheduler jitter; fades progress according to real time instead of assuming perfect 20 ms cadence
  • Reduced lock hold in Universe fader processing to avoid holding the universe fader list lock during potentially expensive per-fader channel writes, reducing contention and improving scalability with many faders/universes
  • Lower allocation/copy pressure in output emission: avoids per-tick temporary copy for plugin output write path while preserving safe ownership semantics for queued signal consumers
  • GenericFader channel lookup/update restructuring: reduces lock churn and repeated channel metadata setup overhead in high-channel scenes
  • Locking correctness improvements in GenericFader: fixes data-race risk and ensures thread-safe mutation behavior
  • Additional performance validation is done through engine/test/universeperf

- Universe::tick() now releases the semaphore only if no pending token exists.
- Elapsed-time aware fading: improves fade timing accuracy under variable CPU load and scheduler jitter; fades progress according to real time
instead of assuming perfect 20 ms cadence
- Reduced lock hold in Universe fader processing to avoid holding the universe fader list lock during potentially expensive per-fader channel writes, reducing contention
and improving scalability with many faders/universes
- Lower allocation/copy pressure in output emission: avoids per-tick temporary copy for plugin output write path while preserving safe ownership semantics for queued
signal consumers
- GenericFader channel lookup/update restructuring: reduces lock churn and repeated channel metadata setup overhead in high-channel scenes
- Locking correctness improvements in GenericFader: fixes data-race risk and ensures thread-safe mutation behavior
- Additional performance validation is done through engine/test/universeperf
@coveralls
Copy link

Coverage Status

coverage: 34.05% (+0.08%) from 33.973%
when pulling 82d3585 on unirework
into 997835b on master.

@mcallegari mcallegari merged commit 5c447d2 into master Mar 17, 2026
27 checks passed
@mcallegari mcallegari deleted the unirework branch March 21, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants