⚡ Optimize addGems to use single atomic DB query

modules/Gem/pom.xml

@@ -64,7 +64,7 @@
         </repository>
         <repository>
             <id>placeholderapi</id>
-            <url>https://repo.extendedclip.com/content/repositories/placeholderapi/</url>
+            <url>https://repo.helpch.at/releases/</url>
         </repository>
     </repositories>
 
@@ -78,8 +78,20 @@
         <dependency>
             <groupId>me.clip</groupId>
             <artifactId>placeholderapi</artifactId>
-            <version>2.11.1</version>
+            <version>2.11.5</version>
             <scope>provided</scope>
         </dependency>
+        <dependency>
+            <groupId>junit</groupId>
+            <artifactId>junit</artifactId>
+            <version>4.13.2</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-core</artifactId>
+            <version>3.12.4</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 </project>

modules/Gem/src/main/java/com/mcatk/gem/Gem.java

@@ -11,7 +11,7 @@
 import java.text.SimpleDateFormat;
 import java.util.Date;
 
-public final class Gem extends JavaPlugin {
+public class Gem extends JavaPlugin {
 
     private static Gem plugin;
     private GemExecutor gemExecutor;

modules/Gem/src/main/java/com/mcatk/gem/GemExecutor.java

@@ -43,16 +43,7 @@ public Integer getTotalGems(String name) {
     }
 
     public void addGems(String name, int addGems) {
-        Integer gems = MySQLManager.getInstance().getGems(name);
-        if (MySQLManager.getInstance().getGems(name) == null) {
-            MySQLManager.getInstance().insertData(name);
-            gems = 0;
-        }
-        Integer total = MySQLManager.getInstance().getTotal(name);
-        gems += addGems;
-        total += addGems;
-        MySQLManager.getInstance().setGems(name, gems);
-        MySQLManager.getInstance().setTotal(name, total);
+        MySQLManager.getInstance().addGems(name, addGems);
         Gem.getPlugin().log(name + "获得宝石" + addGems);
     }
 }

modules/Gem/src/main/java/com/mcatk/gem/sql/MySQLManager.java

@@ -93,6 +93,22 @@ public Integer getTotal(String name) {
         return null;
     }
 
+    public void addGems(String name, int amount) {
+        try (PreparedStatement ps = connection.prepareStatement(
+                "INSERT INTO `gem` (`username`, `gems`, `total`) VALUES (?, ?, ?) " +
+                        "ON DUPLICATE KEY UPDATE `gems` = `gems` + ?, `total` = `total` + ?"
+        )) {
+            ps.setString(1, name);
+            ps.setInt(2, amount);
+            ps.setInt(3, amount);
+            ps.setInt(4, amount);
+            ps.setInt(5, amount);
+            ps.executeUpdate();
+        } catch (SQLException e) {
+            e.printStackTrace();
+        }
+    }
+
     public void setGems(String name, int num) {
         try (PreparedStatement ps = connection.prepareStatement(
                 "UPDATE `gem` SET `gems` = ? WHERE `username` = ?"

modules/Gem/src/test/java/com/mcatk/gem/GemExecutorTest.java

@@ -0,0 +1,73 @@
+package com.mcatk.gem;
+
+import com.mcatk.gem.sql.MySQLManager;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
+
+import java.lang.reflect.Field;
+import java.util.logging.Logger;
+
+import static org.mockito.ArgumentMatchers.anyInt;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.*;
+
+@RunWith(MockitoJUnitRunner.class)
+public class GemExecutorTest {
+
+    @Mock
+    private MySQLManager mySQLManager;
+
+    @Mock
+    private Gem gemPlugin;
+
+    @Mock
+    private Logger logger;
+
+    private GemExecutor gemExecutor;
+
+    @Before
+    public void setUp() throws Exception {
+        // Mock Gem.plugin
+        setStaticField(Gem.class, "plugin", gemPlugin);
+        // when(gemPlugin.getLogger()).thenReturn(logger);
+
+        // Mock MySQLManager.instance
+        setStaticField(MySQLManager.class, "instance", mySQLManager);
+
+        gemExecutor = new GemExecutor();
+    }
+
+    @After
+    public void tearDown() throws Exception {
+        setStaticField(Gem.class, "plugin", null);
+        setStaticField(MySQLManager.class, "instance", null);
+    }
+
+    private void setStaticField(Class<?> clazz, String fieldName, Object value) throws Exception {
+        Field field = clazz.getDeclaredField(fieldName);
+        field.setAccessible(true);
+        field.set(null, value);
+    }
+
+    @Test
+    public void testAddGems_Optimized() {
+        String playerName = "TestPlayer";
+        int gemsToAdd = 100;
+
+        gemExecutor.addGems(playerName, gemsToAdd);
+
+        // Verify that addGems is called exactly once
+        verify(mySQLManager).addGems(playerName, gemsToAdd);
+
+        // Verify that redundant calls are NOT made
+        verify(mySQLManager, never()).getGems(anyString());
+        verify(mySQLManager, never()).getTotal(anyString());
+        verify(mySQLManager, never()).setGems(anyString(), anyInt());
+        verify(mySQLManager, never()).setTotal(anyString(), anyInt());
+        verify(mySQLManager, never()).insertData(anyString());
+    }
+}