β‘ Optimize SQLManager.getMainMedal with JOIN query #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ What:
SQLManager.getMainMedalto use a single SQLINNER JOINquery instead of two sequential queries.SQLManagerto allow dependency injection of theConnectionobject, making it testable.SQLManagerTestusing JUnit 5 and Mockito to verify the behavior.π― Why:
medal_idfromplayer_main_medal, and then to get the medal details frommedal.π Measured Improvement:
prepareStatementtwice.SQLManagerTestto executeprepareStatementonly once while returning the correctMedalobject.PlaceholderAPIdependency. A temporary stub was used to run and verify the tests, which has been removed in the final submission to preserve project integrity. The submitted code assumes a working build environment wherePlaceholderAPIis available.PR created automatically by Jules for task 13960138847256864281 started by @acsoto