Open
Conversation
bedrock.js
Outdated
Collaborator
There was a problem hiding this comment.
instead of exports which is already a variable in Node.js can this just be called Bedrock or something stating that its actually the bedrock object were going to be putting stuff one?
Collaborator
|
In response to all the micro-optimizations you're making to looping through arrays I don't think its worth it. See: jashkenas/backbone#3497 |
updated the README and added documentation
… jQuery-like library if available globally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry this is lumped together but there was a ton of stuff I wanted to change. The goal of this version bump is to both correct some inconsistencies and also clean up some code that seems neglected.
We inherited a bunch of functions that were iterating over objects unsafely and there were a few spots using arguments passed in (which v8 won't optimize).
I also added a ton of documentation (but still incomplete). I think we can write more as time moves along but it's better than the nonexistent docs we have now.
I got rid of the coffeescript dev dependency and removed the model.coffee since it was needlessly duplicating tests from model.js.