feat(TripPlanner): tagged itineraries + feedback form #1879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(TripPlanController): remove extra inputs For the remaining wheelchair accessibility checkbox, make it initially selected. * refactor(OpenTripPlanner): stop merging accessible+inaccessible Because requests without `wheelchair: true` do not compute the accessibilityScore, remove the (misleading, inaccurate) "Might not be accessible" icon from the result. * feat(OTP.Parser): improved error handling
* deps(mix): add open_trip_planner_client * refactor: use OpenTripPlannerClient - deprecate `TripPlan.Api` behaviour and the modules using it (`TripPlan.Api.MockPlanner` and `TripPlan.Api.OpenTripPlanner`) in favor of using the client (`OpenTripPlannerClient` and its behaviour `OpenTripPlannerClient.Behaviour`). - remove `TripPlan.plan/4` function * deps(mix): install Mox * feat(OpenTripPlannerClient.Mock): add test stub * deps(mix): add ex_machina and faker * feat(Test.Support.Factory): trip plan data generation * feat: request itinerary tags * feat: render itinerary tags * fix typings * deps(mix): update OpenTripPlannerClient * refactor: one tag per itinerary * feat(TripPlan.Query): different tags for arrive/depart * fixup: one tag per itinerary
* fixup merge commit * feat(TripPlan.Query): add new MostDirect tag bump open_trip_planner_client version, which adds support for MostDirect tag since v0.6. this also adjusts the returned data slightly, so when parsing we can use the agency name as opposed to parsing the agency GTFS ID. * hotfix for OTPClient error involving parsing routing errors
* fixup: hotfix for OTPClient error involving parsing routing errors * fix: preserve selected modes and wheelchair options
* fixup merge commit * feat(TripPlan.Query): add new MostDirect tag bump open_trip_planner_client version, which adds support for MostDirect tag since v0.6. this also adjusts the returned data slightly, so when parsing we can use the agency name as opposed to parsing the agency GTFS ID. * hotfix for OTPClient error involving parsing routing errors * fixup: hotfix for OTPClient error involving parsing routing errors * fix: preserve selected modes and wheelchair options * cleanup: remove unused component * chore: make TS believe formData.entries() is a thing * chore(TripPlannerResultsTest): change test render use testing-library instead of react-test-renderer * fix: add border to form controls * feat(FeedbackForm): new component * fix (?) snapshot time * fixup: use classes * feedback: style improvements
* deps: bump open_trip_planner_client * chore: stop server-rendering TripPlannerResults * chore(TripPlan.Query): remove unused argument * feat(TripPlanView): add trip_plan_metadata/1 * pass trip plan metadata to frontend * feat(TripPlan.Feedback): submit response to backend * mostly renames * cleanup with some feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a feature branch for several distinct but related Trip planner changes.