fix: properly show error when failing to fetch shape data#1353
Open
fix: properly show error when failing to fetch shape data#1353
Conversation
5de8207 to
7dbf5db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: No Ticket
There's a situation in Arrow where a file can be deleted from S3, but Arrow still tries to retrieve it, and marks it as an error if it fails to retrieve it, if the shuttle is considered 'active'.
There is error handling for this case, but it turns out we're calling
Ecto.Changeset.add_error/4incorrectly, by passing the error term we're returned from various systems into the "message" argument, which is incorrect per the function requirements. This ends up with errors like this in the logs:I assume previous implementers intended any errors to bubble up into the form, per Phoenix/Liveview/Ecto conventions, but by calling
add_errorwrong, we're crashing the process and preventing the UI from doing anything or making the failure state understandable.This serializes the error using
inspectwhich allows the error to be surfaced to the frontend.Before:
Internal server errorAfter:

Reviewer Checklist