Add support for SESSION_COOKIE_SAMESITE #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cript0nauta
added a commit
to infobyte/faraday
that referenced
this pull request
Jan 30, 2020
To fix the vuln, we need to use SameSite cookies. The upstream version of Flask-KVSession doesn't support that, so we forked it, merged the changes in mbr/flask-kvsession#52 and uploaded the new version to PyPI (with the name `flask-kvsession-fork`). I also changed the session cookie name to discard old session cookies that don't have the SameSite attribute unset.
|
@mbr I understand you may not be maintaining this project anymore. Would it be possible to just merge this PR? This would help fix samesite attribute control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the SESSION_COOKIE_SAMESITE configuration option as documented in https://flask.palletsprojects.com/en/1.1.x/config/#SESSION_COOKIE_SAMESITE
(note that this includes the .travis.yml changes from #51)