Skip to content

Feature/query request#68

Open
kamalogudah wants to merge 2 commits intomboya:feature/query-requestfrom
kamalogudah:feature/query-request
Open

Feature/query request#68
kamalogudah wants to merge 2 commits intomboya:feature/query-requestfrom
kamalogudah:feature/query-request

Conversation

@kamalogudah
Copy link
Collaborator

Add Query Request functionality as covered in Lipa Na M-Pesa Query Request API

@kamalogudah kamalogudah requested a review from mboya September 10, 2020 21:15
@mboya
Copy link
Owner

mboya commented Nov 13, 2020

@kamalogudah i would suggest we rename this class into something specific

module MpesaStk
   class LipaMpesa::QueryPayment
   end
end

or have it run the multiple query endpoints in one class.

Reason for this is that i have noticed the endpoint is being used to run over multiple products and would be nice if we account for all.

PS: i have to go through the documentation to try and figure out which part you were targeting.

@kamalogudah kamalogudah force-pushed the feature/query-request branch from 747eae2 to 031bac2 Compare November 28, 2020 23:18
@mboya
Copy link
Owner

mboya commented Nov 30, 2020

Do resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants