Skip to content

Allow reading variable tab height for tab bounds #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willhansen wants to merge 1 commit into
base: v5
Choose a base branch
from
Open

Allow reading variable tab height for tab bounds #1832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/services/sidebar.actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,14 +602,9 @@ export function updateBounds(): void {
function calcTabsBounds(panel: TabsPanel): ItemBounds[] {
// Logs.info('Sidebar.calcTabsBounds', panel.id)
const result: ItemBounds[] = []
const th = Sidebar.tabHeight
const tm = Sidebar.tabMargin
if (th === 0) return result
const half = th >> 1
const marginA = Math.floor(tm / 2)
const marginB = Math.ceil(tm / 2)
const insideA = (half >> 1) + marginB + 2
const insideB = (half >> 1) + marginB - 2

let overallHeight = -marginA
let tabs = Tabs.list
Expand All @@ -624,6 +619,14 @@ function calcTabsBounds(panel: TabsPanel): ItemBounds[] {
if (tab.invisible || tab.pinned) continue
if (tab.panelId !== panel.id) continue

// This method to get tab element taken from: https://github.com/mbnuqw/sidebery/blob/d74c2f70bcd9a980dcec02738a5260b171f5ecc1/src/services/tabs.fg.scroll.ts#L25
const elId = 'tab' + tab.id.toString()
const el = document.getElementById(elId)
const th = el.offsetHeight - tm
const half = th >> 1
const insideA = (half >> 1) + marginB + 2
const insideB = (half >> 1) + marginB - 2

result.push({
type: ItemBoundsType.Tab,
id: tab.id,
Expand Down