Skip to content

Use System.Runtime.Serialization.Formatters NuGet package for .NET 8+ targets #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Use System.Runtime.Serialization.Formatters NuGet package for .NET 8+ targets #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bf6066
Initial plan
Copilot Dec 29, 2025
9297b08
Add System.Runtime.Serialization.Formatters NuGet package for .NET 8 …
Copilot Dec 29, 2025
429c253
Add System.Runtime.Serialization.Formatters package reference to test…
Copilot Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions NET/Mbc.Pcs.Net.DataRecorder.Test/FileRingBufferTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,6 @@ namespace Mbc.Pcs.Net.Test.DataRecorder
{
public class FileRingBufferTest
{
public FileRingBufferTest()
{
#if NET8_0_OR_GREATER
// Enable BinaryFormatter, because in .NET 8.0 it is disabled by default
AppContext.SetSwitch("System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization", true);
#endif
}

[Fact]
public void SmokeTest()
Expand Down
4 changes: 4 additions & 0 deletions NET/Mbc.Pcs.Net.DataRecorder.Test/Mbc.Pcs.Net.DataRecorder.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<Product>Mbc.Pcs.Net.DataRecorder.Test</Product>

<GeneratePackageOnBuild>false</GeneratePackageOnBuild>
<EnableUnsafeBinaryFormatterSerialization Condition="'$(TargetFramework)' == 'net8.0'">true</EnableUnsafeBinaryFormatterSerialization>
</PropertyGroup>
<PropertyGroup>
<NoWarn>NU1702;CS7022</NoWarn>
Expand All @@ -23,6 +24,9 @@
<!--Requires the HDF package reference to find the hdf5.dll-->
<PackageReference Include="HDF.PInvoke" Version="1.10.6.1" Condition="'$(TargetFramework)' == 'net471' OR '$(TargetFramework)' == 'net48'" />
<PackageReference Include="HDF.PInvoke.1.10" Version="1.10.610" Condition="'$(TargetFramework)' == 'netstandard2.0' " />

<!--Use NuGet package for BinaryFormatter on .NET 8.0-->
<PackageReference Include="System.Runtime.Serialization.Formatters" Version="10.0.1" Condition="'$(TargetFramework)' == 'net8.0'" />
</ItemGroup>

<ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion NET/Mbc.Pcs.Net.DataRecorder/Mbc.Pcs.Net.DataRecorder.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<Product>Mbc.Pcs.Net.DataRecorder</Product>

<EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization>
<EnableUnsafeBinaryFormatterSerialization Condition="'$(TargetFramework)' != 'net8.0'">true</EnableUnsafeBinaryFormatterSerialization>
</PropertyGroup>
<PropertyGroup>
<NoWarn>NU1702</NoWarn>
Expand All @@ -16,5 +16,6 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="Mbc.Hdf5Utils" Version="0.7.0" />
<PackageReference Include="System.Runtime.Serialization.Formatters" Version="10.0.1" Condition="'$(TargetFramework)' == 'net8.0'" />
</ItemGroup>
</Project>