Enable support for SIGWINCH reporting through ceKEY_RESIZE#26
Open
m7a wants to merge 1 commit intomazenharake:masterfrom
Open
Enable support for SIGWINCH reporting through ceKEY_RESIZE#26m7a wants to merge 1 commit intomazenharake:masterfrom
m7a wants to merge 1 commit intomazenharake:masterfrom
Conversation
Previously, window resizing was reported to the applications through the opaque key code 410. Also, occasionally, the reported window size was wrong. This commit attempts to fix this by adding a new constant `ceKEY_RESIZE` to detect the virtual key reported by NCurses for resize events. Also, the code is extended to explicitly query the current window size via `ioctl`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, window resizing was reported to the applications through the opaque key code 410. Also, occasionally, the reported window size was wrong.
This commit attempts to fix this by adding a new constant
ceKEY_RESIZEto detect the virtual key reported by NCurses for resize events. Also, the code is extended to explicitly query the current window size viaioctl.I am not sure if this is the right solution, but it seems to be an improvement over the state from before hence I submit it for your consideration 😄