Remove console warning for falsy channel#74
Open
justinwolfe wants to merge 2 commits intomayteio:masterfrom
Open
Remove console warning for falsy channel#74justinwolfe wants to merge 2 commits intomayteio:masterfrom
justinwolfe wants to merge 2 commits intomayteio:masterfrom
Conversation
Author
|
@mayteio Just a lil ping on this for when you have a moment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #44.
Current Behavior:
If
useChannelis passed a falsy value, it returns early with a console warning.Proposed Behavior:
Don't emit the console warning (for my usage of this hook, it's a feature not a bug!)
p.s. I love this library—a huge help!