Update components and fix compilation issues#1
Open
saleyn wants to merge 2 commits intomaxneuvians:masterfrom
Open
Update components and fix compilation issues#1saleyn wants to merge 2 commits intomaxneuvians:masterfrom
saleyn wants to merge 2 commits intomaxneuvians:masterfrom
Conversation
saleyn
commented
Mar 28, 2026
saleyn
commented
- Fixed Pique.Smtp charlist deprecation ('...' → ~c"...")
- Replaced Logger.warn with Logger.warning
- Implemented missing handle_STARTTLS/1 callback
- Updated Pique supervisor startup to use :gen_smtp_server.child_spec/3
- Added test config defaults: auth: false, smtp_opts: [protocol: :tcp]
- Updated tests to use ~c"..." expectations
- Result: mix compile and mix test pass (38 tests)
Store handler modules and auth_enabled flag in session state instead of
module attributes. This enables runtime configuration changes without
recompilation and allows the session limit to be customized at runtime.
**Changes:**
- Initialize handler references and config in init/4 via Application.get_env
- Fetch handlers from state dict in all callbacks
- Fix terminate/2 spec to return {:ok, reason, state}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.