Skip to content

Replaces all instances of for-in loop with Object.keys iter #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexanderscott wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replaces all instances of for-in loop with Object.keys iter #14

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e17ad9
Fixes #2 - replaces all instances of for-in with Object.keys iter
alexanderscott Jul 24, 2014
5c5e48d
fixes linkedEntity key displacement
alexanderscott Jul 24, 2014
2e179b8
fix spacing
alexanderscott Jul 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions lib/musicbrainz.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,8 +548,9 @@ var Resource = function (mbid) {
var self = this;
this._lookup(this.id, linkedEntities, force, function (err, resource) {
if ( !err ) {
for (i in self) {
self[i] = resource[i];
for (var i = 0; i < Object.keys(self).length; i++) {
var key = Object.keys(self)[i];
self[key] = resource[key];
}
}

Expand All @@ -575,9 +576,10 @@ var Resource = function (mbid) {
};

this.readData = function (linkedEntities, data) {
for (var i in linkedEntities) {
if (typeof this._readDataFunctions[linkedEntities[i]] === 'function') {
this._readDataFunctions[linkedEntities[i]](data);
for(var l = 0; l < Object.keys(linkedEntities).length; l++){
var linkedEntity = Object.keys(linkedEntities)[l];
if (typeof this._readDataFunctions[linkedEntities[linkedEntity]] === 'function') {
this._readDataFunctions[linkedEntities[linkedEntity]](data);
}
}
};
Expand Down Expand Up @@ -836,7 +838,8 @@ mb.search = function(resource, query, filter, force, callback){
uri = mbBaseURI + resource + '?query=';

if(filter instanceof Object) {
for(var key in filter){
for(var k = 0; k < Object.keys(filter).length; k++){
var key = Object.keys(filter)[k];
filterArr.push(key + ':' + encodeURIComponent(filter[key]));
}
filterStr = filterArr.join( encodeURIComponent(' AND ') );
Expand Down