Skip to content

Conversation

@yeager
Copy link
Contributor

@yeager yeager commented Jun 4, 2025

No description provided.

@maximeh maximeh self-assigned this Jun 4, 2025
@maximeh
Copy link
Owner

maximeh commented Jun 4, 2025

As far as I can tell; only 8e9110a should be needed; the previous one looks identical to what's already in main? Am I missing something?

@yeager
Copy link
Contributor Author

yeager commented Jun 4, 2025

You are correct. Maybe previous PR was merged but not closed?

@maximeh
Copy link
Owner

maximeh commented Jun 5, 2025

Hm when I look at #24; it's both merged and closed so I'm confused

@yeager
Copy link
Contributor Author

yeager commented Jun 5, 2025

I'll blame Github then :) All looks ok

@maximeh
Copy link
Owner

maximeh commented Jun 5, 2025

I'll blame Github then :) All looks ok

agreed

@maximeh maximeh merged commit 3c0ab1d into maximeh:main Jun 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants