Fix: test_long_password for bcrypt 5+ strict limit#96
Open
kirillrdy wants to merge 1 commit intomaxcountryman:masterfrom
Open
Fix: test_long_password for bcrypt 5+ strict limit#96kirillrdy wants to merge 1 commit intomaxcountryman:masterfrom
kirillrdy wants to merge 1 commit intomaxcountryman:masterfrom
Conversation
3 tasks
dotlambda
reviewed
Nov 30, 2025
Update test_bcrypt.py Co-authored-by: dotlambda <github@dotlambda.de>
kirillrdy
force-pushed
the
fix-bcrypt-limit
branch
from
3d997d2 to
b2c5a63
Compare
|
FWIW I think bcrypt 4.2.0 is fine - the problem arises with bcrypt >= 5.0.0. |
kirillrdy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test 'test_long_password' in 'BasicTestCase' was failing due to bcrypt's strict 72-byte limit for passwords when used with bcrypt 5+. This commit truncates the password used in the check_password_hash call to 72 bytes, aligning the test with bcrypt's behavior of ignoring bytes beyond that limit, and preventing ValueError.