autopairs integration

[HyperAfnan]

No description provided.

[HyperAfnan]

Hey Max, Sorry it took me a while because I got some urgent work yesterday.
I have added autopairs with the use of pcall() for testing 
And if it goes well. We can make an integration.autopairs field in the care.config that can be used to toggle the autopairs integration code and later it can be used to add integrations for more plugins like tabout or any icon plugin .

[HyperAfnan]

hey @max397574 any update? does it work for you?

[max397574]

I will test this out later
the code looks good and it is the correct place to add it

I'm not sure if we want plugin-specific code in the codebase
I'm not directly against it but I don't like it in this location

I think the best solution would be to have a module somewhere where these integrations are stored and we also create a builtin one (which just adds the ()). I could also add the builtin one myself later

configuration would then either be an option which takes a callback (so a function, to which the entry gets passed)
or we just tell users to create an autocmd (because there already are autocommands (not sure if there are at the end of confirming but if not it's easy to add))

[max397574]

looks good so far
see my comment for more information

[max397574]

note to myself: add to docgen so it gets link after merging

[max397574]

still use pcall and use vim.notify to give a warning if autopairs is not available

because some people always manage to mess things up like this and I'd rather not get people reporting errors

[HyperAfnan]

okey ill use pcall and vim.notify

[HyperAfnan]

I think the best solution would be to have a module somewhere where these integrations are stored and we also create a builtin one (which just adds the ()). I could also add the builtin one myself later

okey I'll the integration code into a module

configuration would then either be an option which takes a callback (so a function, to which the entry gets passed)
or we just tell users to create an autocmd (because there already are autocommands (not sure if there are at the end of confirming but if not it's easy to add))

Are you saying to make it like this for the autocmd part?

cmp.event:on(
				"confirm_done",
				cmp_autopairs.on_confirm_done({
					filetypes = {
						["*"] = {
							["("] = {
								kind = {
									cmp.lsp.CompletionItemKind.Function,
									cmp.lsp.CompletionItemKind.Method,
								},
								handler = handlers["*"],
							},
						},
					},
				})
			)

this is the code to integrate nvim-cmp with nvim-autopairs

[max397574]

yes similar like what cmp does

except that we use autocommands and not a weird self-built even system

what do you think?
should we rather use a callback in the config or an autocmd?
I'd personally say autocmd because 1. there are a ton of config options already and 2. we don't know if more callback will exist in the future

[HyperAfnan]

Yeah I also think adding autocmd would be a great idea
it will also allow people to use other plugins like nvim-autopairs such as ultimate-autopairs or mini.pairs

[max397574]

@HyperAfnan do you think you'll find time to finish this soon?

Otherwise I could take this over

[HyperAfnan]

Sorry, this week was too hectic for me, but tomorrow is Sunday, so I'll complete this by tomorrow.

[max397574]

No worries
I myself I'm often quite busy and just would have picked this up if you wouldn't have been able to work on it during the next few weeks

[HyperAfnan]

Hey max , I have created an event listener for the event called confirm_done which is called in the care/menu/confirm.lua file

[max397574]

#118 (comment)

except that we use autocommands and not a weird self-built even system

😳

[HyperAfnan]

can you tell me how should it look like ? I'm out of ideas

[max397574]

well just how it was before
with a user autocmd

and then just add the code for the autopairs logic somewhere and a configuration recipe with how to setup the autocmd

[HyperAfnan]

okey i gotcha