Skip to content

don't crash on socket error #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Juul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't crash on socket error #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ function WebSocketStream(target, protocols, options) {
socket.onerror = onerror
socket.onmessage = onmessage

proxy.on('error', function(){})
Copy link
Copy Markdown

@DmitryMyadzelets DmitryMyadzelets Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore errors? It can lead to even more long debugging then you have had.

Copy link
Copy Markdown
Author

@Juul Juul Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we have two options here: Ignore unhandled errors or have unhandled errors lead to crashes. My first pull request was to document how to handle errors so you don't have crashes and I was asked to instead fix the issue. I don't think there is a third option but I'd be very happy to learn something.


proxy.on('close', destroy)

var coerceToBuffer = !options.objectMode
Expand Down