Development

[balaktsis]

No description provided.

[Copilot]

Pull Request Overview

This PR adds CSV ingestion support to ReadLogFile by introducing a new readFromCSV method and extending the file‐type dispatch logic.

• Added java.sql.Timestamp import and CSV file type branch in the dispatcher.
• Implemented readFromCSV to read, group, sort, and convert CSV data into Sequence objects.
• Included a sample test.csv for experimental input.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/main/scala/auth/datalab/siesta/BusinessLogic/IngestData/ReadLogFile.scala	Extended file‐type dispatch and added CSV ingestion method
experiments/input/test.csv	Added sample CSV log data

Comments suppressed due to low confidence (3)

src/main/scala/auth/datalab/siesta/BusinessLogic/IngestData/ReadLogFile.scala:197

• No tests exist for the new CSV ingestion path; consider adding unit or integration tests to verify parsing, ordering, and position assignment in readFromCSV.

def readFromCSV(fileName: String): RDD[Sequence] = {

src/main/scala/auth/datalab/siesta/BusinessLogic/IngestData/ReadLogFile.scala:50

• The exception message is generic; consider using a more specific exception type or including the offending fileName and supported formats to aid debugging.

throw new Exception("Not recognised file type")

src/main/scala/auth/datalab/siesta/BusinessLogic/IngestData/ReadLogFile.scala:197

• Add a Scaladoc comment above readFromCSV describing its behavior, parameters, and return value to improve code readability and maintenance.

def readFromCSV(fileName: String): RDD[Sequence] = {