[IE-962] Bump dependency to allow faraday 2 releases #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkinsondesouza
commented
Jan 9, 2025
Comment on lines
+8
to
+9
| require "faraday/follow_redirects" | ||
| require "faraday/multipart" |
Author
There was a problem hiding this comment.
💡 These middleware were split into their own gems
wilkinsondesouza
requested review from
b6b,
dezkowalski,
jarednielson,
marioconcilio and
ncperry
Co-authored-by: Wilkinson de Souza <wilkinson.desouza@kantata.com>
wilkinsondesouza
force-pushed
the
ie-962-allow-faraday-2
branch
from
175c994 to
a34e496
Compare
jarednielson
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to move away from Faraday 1.0 in Konekti but this gem strictly requires us to use 1.x.
This pull request aims to bump the dependencies so we solve the Faraday problem and also
Notes
Some middleware needed to be changed so we followed Awesome Faraday instructions.