-
Notifications
You must be signed in to change notification settings - Fork 0
Keep v2 support for search #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep v2 support for search #23
Conversation
ajitkantata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b6b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like bringing back the old implementation 👍
@mavenlink/integrations-solutions The one thought I have is that this unfortunately just moves old behavior to a different method instead of keeping it fully compatible. It will be a bit of an annoyance changing things again, but what does everyone thing of preferring to keep this self.jql and updating the v3 search to be self.jql_v3?
ananta0799
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thats interesting, but why I kept the v3 as |
I understand that v3 will be the default for search but reviewing the pattern on your other PR, I think |
ba6db83
into
IE-1122_update_deprecated_jira_apis
Enable the support for v2 search as well, as for some clients using on-prem server for jira, v3 is not yet supported. The client can call
jql_v2and the gem would hit the v2 search api.