-
Notifications
You must be signed in to change notification settings - Fork 0
IE 1122 update deprecated jira apis #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| stub_request( | ||
| :get, | ||
| site_url + '/jira/rest/api/2/search?jql=id IN(10001, 10000)' | ||
| 'http://foo:bar@localhost:2990' + '/jira/rest/api/3/search/jql?jql=id IN(10001, 10000)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
b6b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it seems reasonable to me. I like adding a separate path we are just using for search. Just one question on naming.
In the future we can probably consolidate this back into one path if we want to fully upgrade to v3.
Updated the jira search deprecated APIs to the new apis provided by Atlassian,
https://developer.atlassian.com/changelog/#CHANGE-2046.
Also please note this statement mentioned in the changelog
We’ll replace random page access with a continuation token API. This means you won’t be able to get multiple pages at the same time with parallel threads. startAt parameter will be replaced with nextPageToken.This means that the client of this jira-ruby gem can't use the
startAtparameter but needs this gem to send thenextPageTokenin response and subsequently that token will be used by the client to fetch the successive pages in their requests. So if you are back from future because of any error, might want to take a look at this info. 😄