handlematrix,handlewhatsapp: support add/remove participant, handle member change in e2e group #211
+115
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
Jan 26, 2026
pkg/connector/capabilities.go
Outdated
Comment on lines
164
to
167
| MemberActions: map[event.MemberAction]event.CapabilitySupportLevel{ | ||
| event.MemberActionInvite: event.CapLevelFullySupported, | ||
| event.MemberActionKick: event.CapLevelFullySupported, | ||
| }, |
Member
There was a problem hiding this comment.
These should only be set in igCapsGroup and metaCapsGroup. I guess metaCapsWithE2E also needs to be split up to have groups separately
tulir
reviewed
Jan 26, 2026
pkg/connector/handlewhatsapp.go
Outdated
| } | ||
| } | ||
| for _, userID := range evt.Leave { | ||
| memberChanges.MemberMap[metaid.MakeWAUserID(userID)] = bridgev2.ChatMember{ |
Member
There was a problem hiding this comment.
memberChanges.MemberMap.Set(bridgev2.ChatMember{...}) is preferred over manually setting map entries (that way the user ID doesn't need to be repeated)
tulir
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.