Merged
Conversation
…ther more minor changes mentioned in the modifications docx file.
… files. Also implemented @scanf for some parsing
…nversion to scanf
Contributor
Author
|
I just did a test where I read in an ASCII uff58 file and wrote it out in binary and then back. I tested all three and the data is \approx equal. So this is gratifying. The file uff58_nospacing.uff is 6668 KB. When written in binary it is 2002 KB. Nice saving. I found a bug which I fixed and added some test. The tests need to be made elegant yet. |
maucejo
approved these changes
Nov 20, 2025
maucejo
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did a similar refactor to write_datasets as to parse_datasets, so as to be able to write binary files.
I did this to all filetypes except the 2000 ones, as you were going to work on them.
I did a spotty change to using @scanf in some places, but was not thorough with this. (Time constraints ) It does seem to work well though.
the testing done so far indicates that it is working.