Change to __weak from __unsafe_unretained to fix crashes during unit … #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testing of many threaded HTTP responses in WebApiClient project.
msqr
added a commit
to Blue-Rocket/WebApiClient
that referenced
this pull request
Oct 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…testing of many threaded HTTP responses in WebApiClient project unit tests. I kept getting crashes from the
setHeadersForResponse:error:method, on the line that calls[http.defaultHeaders enumerateKeysAndObjectsUsingBlock:...and I noticed the__unsafe_unretainedivar. Switching to__weakresolved the crashes for me.