-
Notifications
You must be signed in to change notification settings - Fork 122
feat: add disable https first features #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, same comment as for the other PR. Aiming to add test today. |
|
For some reason the flag is not working on linux |
When Chrome receives two separate |
|
I reverted that and tested with the single value and still didnt work so there is probably more. It does work on macos and on chromium on Linux from my testing. It might be the default browser it decides to use on GHA doesn't support the flag? We should probably supply the one we want to use for testing. I just launched a run, you will see. This is interesting to know though since that means we need to start accumulating those in vec. We should expose a |
|
Tested this in an Specifically:
Despite these changes, the tests continue to fail in CI but pass when run locally. Example GHA: test-integration:
name: Test Integration
needs: [fmt, clippy, msrv]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: dtolnay/rust-toolchain@stable
- name: Setup Chrome
uses: browser-actions/setup-chrome@v2
with:
chrome-version: latest
id: setup-chrome
- name: Set CHROME_BIN
run: echo "CHROME_BIN=${{ steps.setup-chrome.outputs.chrome-path }}" >> $GITHUB_ENV
- name: Install Xvfb (virtual display for headed mode)
run: sudo apt-get update && sudo apt-get install -y xvfb
- name: Run integration tests with headed Chrome
run: xvfb-run -a bash -c "RUST_TEST_THREADS=1 cargo test --test '*'"Alternative solution: If the goal is simply to get the test passing, we can switch to http://neverssl.com as the test url, which already passes when running under the local |

Fixes #276