Skip to content

Fix: invoke callback when geocoding returns empty results#91

Draft
Copilot wants to merge 2 commits intofix/emulator-location-overridefrom
copilot/sub-pr-90
Draft

Fix: invoke callback when geocoding returns empty results#91
Copilot wants to merge 2 commits intofix/emulator-location-overridefrom
copilot/sub-pr-90

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 22, 2026

When withGeocodeCoordinates receives an empty result set from the geocoding API, it logged and returned without ever calling callback, silently stalling the entire fetch chain. This is the same class of bug the location override stabilization PR addresses.

Changes

  • src/pkjs/weather/provider.js: Call callback(null, null) in the locations.length === 0 branch so the fetch chain can proceed or fail cleanly
if (locations.length === 0) {
    console.log('[!] No geocoding results')
    callback(null, null);  // was: no callback call — fetch stalled silently
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: mattrossman <22670878+mattrossman@users.noreply.github.com>
Copilot AI changed the title [WIP] Update emulator location override stabilization based on feedback Fix: invoke callback when geocoding returns empty results Feb 22, 2026
Copilot AI requested a review from mattrossman February 22, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants