Fix: invoke callback when geocoding returns empty results#91
Draft
Copilot wants to merge 2 commits intofix/emulator-location-overridefrom
Draft
Fix: invoke callback when geocoding returns empty results#91Copilot wants to merge 2 commits intofix/emulator-location-overridefrom
Copilot wants to merge 2 commits intofix/emulator-location-overridefrom
Conversation
Co-authored-by: mattrossman <22670878+mattrossman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update emulator location override stabilization based on feedback
Fix: invoke callback when geocoding returns empty results
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
withGeocodeCoordinatesreceives an empty result set from the geocoding API, it logged and returned without ever callingcallback, silently stalling the entire fetch chain. This is the same class of bug the location override stabilization PR addresses.Changes
src/pkjs/weather/provider.js: Callcallback(null, null)in thelocations.length === 0branch so the fetch chain can proceed or fail cleanly✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.