Feature/performance updates #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed PipeStreamContentsAsync and PipeStreamContents methods, replacing them with direct calls to CopyToAsync and CopyTo. This simplifies the code, enhances readability, and may improve performance.
There was a problem hiding this comment.
Pull Request Overview
Adds performance-oriented updates by guiding users to disable armouring for large files and streamlining internal data piping.
- Introduces a “Performance” section in README.md on disabling armouring.
- Replaces custom
PipeStreamContentshelpers withStream.CopyTo/CopyToAsync. - Removes buffer-based overloads and associated helper methods from
Utilities.cs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Added a performance section explaining how to disable armouring |
| PgpCore/Helpers/Utilities.cs | Swapped manual buffer loops for built-in CopyTo methods and removed unused helpers and overloads |
Comments suppressed due to low confidence (2)
PgpCore/Helpers/Utilities.cs:384
- Add or update unit tests to verify that
CopyToAsynccorrectly handles the full range of input sizes and edge cases, matching the previous behavior of custom buffering.
await input.CopyToAsync(pOut);
PgpCore/Helpers/Utilities.cs:395
- Removing the public overloads that accept a custom buffer is a breaking change; consider marking this as deprecated or bumping the major version to alert consumers.
public static async Task WriteStreamToLiteralDataAsync(
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.