Changes to enable the build process to work on Xcode 10.1 / OS X High… #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Sierra. - The verify_noerr macro has been removed in High Sierra, so a macro has been added to utilize the alternative __Verify_noErr - The path to the compiled .kext module in build.rb did not match the location on disk where it was being built. This has been correct from Build/InstallerRoot/System/Library/Extensions/Soundflower.kext to Build/InstallerRoot/Library/Extensions/Soundflower.kext These appear to be the minimal changes required for the kernel module to build cleanly on the combination of Xcode 10.1 and High Sierra.
…blows it away at the end of the script!)
|
Thanks for your efforts @ajnewlands. It's unfortunate Rogue Amoeba won't support the project any further and they would probably not merge this PR. |
|
@ajnewlands hello, can not build not build in Xcode 10.1, |
henrik242
approved these changes
Aug 28, 2019
|
@mattingalls Have you been looking at this? |
|
@ajnewlands Hi, I tried to run ./build.rb from your branch, It still gives the error: It seems the Soundflower.kext won't be built to the correct path, since there is no such path {@svn_root}/Build/InstallerRoot/System/Library/Extensions/Soundflower.kext |
Author
|
@ronggong I don't actually own a mac to try building this on, but if I have some spare time this week I'll try it on one of our build boxes at the office and see what I can do. |
|
any news ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Sierra.
This has been correct from Build/InstallerRoot/System/Library/Extensions/Soundflower.kext to Build/InstallerRoot/Library/Extensions/Soundflower.kext
These appear to be the minimal changes required for the kernel module to build cleanly on the combination of Xcode 10.1 and High Sierra.