Allow the enduser to provide headers to the generic auth request#31
Open
sriedel wants to merge 1 commit intomatthewoden:masterfrom
Open
Allow the enduser to provide headers to the generic auth request#31sriedel wants to merge 1 commit intomatthewoden:masterfrom
sriedel wants to merge 1 commit intomatthewoden:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial fix for #30 .
I've had issues running the tests: The local vault setup as per README file doesn't quite work with current Vault versions, at least I keep getting SSL related issues in all the permutations I've tried ("http response for https request", "unknown CA" etc).
I have tested the changes against a productive vault server though.