Fix monthByName

[tiff]

setDate() expects an integer from 1 - 31 (not from 0 - 30).
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/setDate

Yeah I know, javascript's date methods are quite inconsistent...

[tiff]

Okay, stop, don't merge this. Tests are failing. I'm checking.

[tiff]

Seems that the test assertions are not expecting what they should. This requires some more investigation.
The fix I proposed is definitely right and does what it should.

I worked on a separate fork for adding support for different languages (and support other date formats).
You can check it out here:
https://github.com/protonet/date

It supports German and it's quite easy to add more languages.
Also it supports time formats like "at 5 o'clock"

[matthewmueller]

Cool project!

I have a feeling there was a reason for the -1. If the tests are failing because of this PR, please update the tests.

You may also want to check if it's unrelated to this PR. In the past we've had tests that fail at certain times of the day. This should have been fixed, but one might have slipped in with a PR.