Adding tests #12
Merged
Adding tests #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rate Limiting Header Fixes: - Simplified get_rate_limit_headers function to handle different tuple structures - Fixed tuple unpacking error in rate limit header extraction - Made header extraction more resilient to different rate limit data formats - Maintained consistent header output format across all endpoints Database Session Handling: - Modified get_db_session to handle RateLimitExceeded exceptions gracefully - Added RateLimitExceeded to expected exceptions alongside HTTPException - Prevented unnecessary error logging for expected rate limit exceptions - Ensured proper database session cleanup in all scenarios Test Improvements: - Simplified rate limit mock in tests to set info before exceptions - Fixed view_rate_limit tuple structure in tests - Ensured consistent rate limit data structure across all tests - Fixed failing tests for no-auth and auth scenarios These changes improve the reliability of rate limiting, fix database session handling during rate limit exceptions, and ensure consistent behavior across all API endpoints while maintaining proper test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.