AS-215 version in build artifact file name#249
AS-215 version in build artifact file name#249bhiln wants to merge 9 commits intomttr-rebase-4.0from
Conversation
This reverts commit 3272b4b.
|
Check hash, this may be the wrong hash |
| MTTR_GIT_TAG=$(echo $(git tag -l "mttr-*" --sort=-committerdate | head -1) | tr - _) | ||
|
|
||
| # Get mttr git hash | ||
| MTTR_GIT_HASH=$(git rev-parse --short=7 HEAD) |
There was a problem hiding this comment.
When this gets run is very important. It must be run after the commit gets merged to the main for this to work. If you can run a test that shows the hash is correct we can leave this in. Otherwise it will cause way more confusion than its worth.
There was a problem hiding this comment.
You are right. I ensured that it worked well on my pc, but I'm not sure it was right from circleci. I'm looking into this.
There was a problem hiding this comment.
@robkarol Here's the latest push with correct hash in the files: https://github.com/matternet/ardupilot/actions/runs/4008770308
|
This change may not be needed depending on a few conversations I have later this week. Lets hold off on merging it for now, also pending the test I suggested in the review. |
github actions already runs on push using the correct commit hash. This covers push, PR, and merges.
2 participants
Add AP version, latest mttr git tag in commit history, and git commit to
.apjand.elfbuild artifact files.