Skip to content

ci: adjust scanner actions #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NARSimoes merged 1 commit into from
Mar 20, 2026
Merged

ci: adjust scanner actions #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,5 @@ jobs:
with:
version: v0.7.1

- name: ci/scan-docker-security
uses: aquasecurity/trivy-action@0.10.0
with:
image-ref: "mattermost/node-rotator"
format: "table"
ignore-unfixed: true
vuln-type: "os,library"
severity: "CRITICAL"

- name: ci/docker-push-pr
run: make push-image-pr
7 changes: 0 additions & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ GOLANGCILINT_VER := v1.50.1
GOLANGCILINT_BIN := golangci-lint
GOLANGCILINT := $(TOOLS_BIN_DIR)/$(GOLANGCILINT_BIN)

TRIVY_SEVERITY := CRITICAL
TRIVY_EXIT_CODE := 1
TRIVY_VULN_TYPE := os,library

export GO111MODULE=on

all: check-style unittest fmt
Expand Down Expand Up @@ -68,9 +64,6 @@ binaries: ## Build binaries of Rotator
GOOS=linux GOARCH=arm64 CGO_ENABLED=0 $(GO) build -gcflags all=-trimpath=$(PWD) -asmflags all=-trimpath=$(PWD) -a -installsuffix cgo -o build/_output/bin/rotator-linux-arm64 ./cmd/$(APP)
GOOS=darwin GOARCH=arm64 CGO_ENABLED=0 $(GO) build -gcflags all=-trimpath=$(PWD) -asmflags all=-trimpath=$(PWD) -a -installsuffix cgo -o build/_output/bin/rotator-darwin-arm64 ./cmd/$(APP)

.PHONY: scan
scan:
trivy image $(ROTATOR_IMAGE)
# Builds the docker image
.PHONY: build-image
build-image: ## Build the docker image for rotator
Expand Down
Loading