[GH-773]: Fixed Issue Jira's autolink should support issue links that contain a comment link in the URL by Kshitij-Katiyar · Pull Request #871 · mattermost/mattermost-plugin-jira

Kshitij-Katiyar · 2022-09-21T12:58:04Z

Summary

Currently the autolink config used by this plugin converts issue links to shorthand links, but it does not work when the originally posted URL has a comment link at the end of the posted URL. Fixed this issue updated the pattern for focusedCommentId as well.
This PR contains all the changes from Pr #839. So this PR alone is enough to fix this issue so we can close Pr #839 afterward.

Issue

#2) * [MI-2119]: Jira's autolink should issue links that contain a comment link in the URL * [MI-2119]: Review fixes 1. Chnaged the name of few variables * [MI-2119]:Review fixes 1. Changed the name of a variable

mattermod · 2022-09-21T12:58:08Z

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

server/plugin.go

javaguirre

Let me know when you can review this!

* [MI-2119]: Jira's autolink should issue links that contain a comment link in the URL * [MI-2119]: Review fixes 1. Chnaged the name of few variables * [MI-2119]:Review fixes 1. Changed the name of a variable * [MI-2199]: Review fixes done 1. Added constants * [MI-2199]:Review fixes 1. Added constants properly * [MI-2119]: Review fixes done 1. Changed the name of the variable * [MI-2119]: Review fixes done 1.Improved code quality * [MI-2119]:Review Fixes 1. Changed the name of variable

javaguirre

Thank you very much for the effort!

javaguirre · 2022-10-04T07:21:22Z

Could you post a video on how to use this new change? Something like this so it's easier to QA.

#863 (comment)

Thank you!

Nityanand13 · 2022-10-05T11:00:48Z

Could you post a video on how to use this new change? Something like this so it's easier to QA.

#863 (comment)

Thank you!

Vedio link for this PR:
https://drive.google.com/file/d/1ucoAzdEsrFd5L5Pw5W5XQPyw-6BVdCY_/view?usp=sharing

javaguirre · 2022-10-06T08:18:55Z

Can't see the video, could you please check if you can upload a compatible format with Drive? Thank you @Nityanand13 !

Nityanand13 · 2022-10-06T09:20:31Z

Can't see the video, could you please check if you can upload a compatible format with Drive? Thank you @Nityanand13 !

Vedio link for this PR:
Fixed_Issue_Jira_autolink_should_support_issue_links_that_contain_a_comment_link_in_the_URL.webm

I think now it should be visible

mickmister · 2022-10-13T21:16:47Z

@Kshitij-Katiyar I'm thinking we should have tests in the autolink repo to test these regex changes, like mattermost-community/mattermost-plugin-autolink#189. Please let me know your thoughts on this 👍

Nityanand13 · 2022-10-18T12:30:34Z

@Kshitij-Katiyar I'm thinking we should have tests in the autolink repo to test these regex changes, like mattermost/mattermost-plugin-autolink#189. Please let me know your thoughts on this +1

@mickmister Test cases for these regex changes have already been written and it is even merged in the master as well. You can look at here: #L121. And there is no any changes in regex after that

mickmister · 2022-10-27T15:37:00Z

Thanks @Nityanand13! Do you know the behavior of backwards compatibility for this feature? If I have existing autolinks present from previous versions of the Jira plugin, what is the result when I upgrade the plugin? Do I have any duplicate autolink entries?

mattermod · 2022-11-07T01:01:36Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Nityanand13 · 2022-11-22T11:24:08Z

Thanks @Nityanand13! Do you know the behavior of backwards compatibility for this feature? If I have existing autolinks present from previous versions of the Jira plugin, what is the result when I upgrade the plugin? Do I have any duplicate autolink entries?

If I have an existing autolink present from the previous versions of the Jira plugin and when I upgrade the plugin with this feature then it is not working. To see this feature, we should remove the mattermost-autolink field from config.json of the mattermost server and restart the server after upgrading the plugin with the new autolink regex.

mickmister · 2022-12-01T15:20:10Z

If I have an existing autolink present from the previous versions of the Jira plugin and when I upgrade the plugin with this feature then it is not working. To see this feature, we should remove the mattermost-autolink field from config.json of the mattermost server and restart the server after upgrading the plugin with the new autolink regex.

@Nityanand13 The feature needs to be backwards compatible if possible. If there are breaking changes, we need to be clear with release notes about what the admin needs to do manually to have the plugin operating as intended. We'll also need to release the plugin as a new major version 4.0.0.

mickmister · 2022-12-01T15:20:35Z

@Nityanand13 What is the behavior if the admin does not remove the entries from config.json?

Nityanand13 · 2022-12-02T10:24:53Z

@Nityanand13 What is the behavior if the admin does not remove the entries from config.json?

@mickmister In the mattermost-autolink field inside config.json, we have the links field which is the array of objects that contains the information about the link that is supported like the template, pattern, scope, etc. When I upgrade the plugin with this feature then the information about the new types of links gets appended at the last of this array. And now if publish a comment link in the mattermost, then its pattern gets matched with the pattern of the issue link present earlier in the array while the pattern of the comment link is at the last of the array.
And when we remove the mattermost-autolink field from config.json and restart the server then that array gets modified such that the information about the comment link comes first.

[MI-2949]:Added a check to remove pre existing autolinks

…s on autolink

[MM-183] Add lock to avoid race conditions while performing operations on autolink

… into mm-773

wiggin77

Let me know when this is ready - I'm removing from my queue for now.

Kshitij-Katiyar · 2025-05-21T09:37:52Z

@avas27JTG @wiggin77 We have fixed this PR. Please review this

AayushChaudhary0001 · 2025-05-26T09:08:36Z

While testing this PR it seems that the code changes are not working fine , let me know if I am missing something

Kshitij-Katiyar · 2025-05-28T13:13:20Z

#1207 is a recreation of this PR with all the changes hence closing this one

Kshitij-Katiyar requested a review from mickmister as a code owner September 21, 2022 12:58

mattermod added the Contributor label Sep 21, 2022

[mm-773]:fixed CI error

2d0d0a7

javaguirre reviewed Sep 23, 2022

View reviewed changes

server/plugin.go Show resolved Hide resolved

javaguirre self-requested a review September 29, 2022 08:07

javaguirre suggested changes Sep 29, 2022

View reviewed changes

Kshitij-Katiyar requested review from javaguirre and removed request for mickmister September 30, 2022 10:07

javaguirre approved these changes Sep 30, 2022

View reviewed changes

javaguirre added the 3: QA Review Requires review by a QA tester label Oct 11, 2022

javaguirre requested a review from DHaussermann October 11, 2022 16:00

mattermod added the Lifecycle/1:stale label Nov 7, 2022

hanzei requested a review from mickmister November 29, 2022 14:11

hanzei added 2: Dev Review Requires review by a core committer and removed Lifecycle/1:stale labels Nov 29, 2022

Kshitij-Katiyar and others added 5 commits April 7, 2023 16:41

[MI-2949]:Fixed self review comment

f3d5b67

Merge pull request #45 from Brightscout/MI-2949

df69291

[MI-2949]:Added a check to remove pre existing autolinks

[MM-183] Add lock to avoid race conditions while performing operation…

7f3cad2

…s on autolink

Merge pull request #75 from Brightscout/MM-183

c0eb515

[MM-183] Add lock to avoid race conditions while performing operations on autolink

Merge branch 'master' of github.com:mattermost/mattermost-plugin-jira…

ed82d42

… into mm-773

raghavaggarwal2308 self-requested a review July 14, 2024 15:49

raghavaggarwal2308 assigned Kshitij-Katiyar Jul 14, 2024

raghavaggarwal2308 requested a review from wiggin77 as a code owner July 14, 2024 15:50

wiggin77 requested changes Aug 20, 2024

View reviewed changes

raghavaggarwal2308 added this to the v4.3.0 milestone Sep 18, 2024

Kshitij-Katiyar force-pushed the mm-773 branch from d26c7b5 to ed82d42 Compare May 21, 2025 08:12

Kshitij-Katiyar added 3 commits May 21, 2025 14:49

Merge remote-tracking branch 'mm/master' into mm-773

43906a4

removed unused code

b122f84

improved code style

e7da2d3

Kshitij-Katiyar requested review from avas27JTG and wiggin77 May 21, 2025 09:30

Kshitij-Katiyar added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester and removed Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) Lifecycle/frozen Contributor labels May 21, 2025

Kshitij-Katiyar mentioned this pull request May 21, 2025

Add delete old autlolink functionality when crud is added to autolink #1205

Open

wiggin77 approved these changes May 21, 2025

View reviewed changes

avas27JTG approved these changes May 23, 2025

View reviewed changes

abbas-dependable-naqvi mentioned this pull request May 28, 2025

comment_autolink_support #1207

Open

Kshitij-Katiyar closed this May 28, 2025

raghavaggarwal2308 deleted the mm-773 branch August 18, 2025 07:57

Conversation

Kshitij-Katiyar commented Sep 21, 2022 • edited by hanzei Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattermod commented Sep 21, 2022

Uh oh!

Uh oh!

javaguirre left a comment

Choose a reason for hiding this comment

Uh oh!

javaguirre left a comment

Choose a reason for hiding this comment

Uh oh!

javaguirre commented Oct 4, 2022

Uh oh!

Nityanand13 commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javaguirre commented Oct 6, 2022

Uh oh!

Nityanand13 commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mickmister commented Oct 13, 2022

Uh oh!

Nityanand13 commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mickmister commented Oct 27, 2022

Uh oh!

mattermod commented Nov 7, 2022

Uh oh!

Nityanand13 commented Nov 22, 2022

Uh oh!

mickmister commented Dec 1, 2022

Uh oh!

mickmister commented Dec 1, 2022

Uh oh!

Nityanand13 commented Dec 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wiggin77 left a comment

Choose a reason for hiding this comment

Uh oh!

Kshitij-Katiyar commented May 21, 2025

Uh oh!

AayushChaudhary0001 commented May 26, 2025

Uh oh!

Kshitij-Katiyar commented May 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Kshitij-Katiyar commented Sep 21, 2022 •

edited by hanzei

Loading

Nityanand13 commented Oct 5, 2022 •

edited

Loading

Nityanand13 commented Oct 6, 2022 •

edited

Loading

Nityanand13 commented Oct 18, 2022 •

edited

Loading

Nityanand13 commented Dec 2, 2022 •

edited

Loading