Skip to content

Update setup flow guidelines#1292

Merged
nevyangelova merged 1 commit intomasterfrom
MM-67658-remove-attachment-reference
Mar 26, 2026
Merged

Update setup flow guidelines#1292
nevyangelova merged 1 commit intomasterfrom
MM-67658-remove-attachment-reference

Conversation

@nevyangelova
Copy link
Copy Markdown
Contributor

@nevyangelova nevyangelova commented Mar 25, 2026

Summary

Update setup guidelines for clearer and up-to-date instructions

Ticket Link

https://mattermost.atlassian.net/browse/MM-67777
https://mattermost.atlassian.net/browse/MM-67658

Change Impact: 🟢 Low

Reasoning: This PR updates instructional text and setup guidance in the OAuth configuration and webhook setup steps. The changes are purely documentation clarifications that do not alter any functional code, authentication mechanisms, or core business logic.

Regression Risk: Negligible. The modifications are guidance text updates in the setup UI flow. No functional code paths, authentication logic, or data handling are affected. Existing integrations continue to work unchanged, and the instructions simply provide clearer guidance for new configurations.

QA Recommendation: Manual QA can be minimal or skipped. These are documentation updates with no functional impact. A brief UI walkthrough to verify the updated text displays correctly in the setup flow wizard would be sufficient. No functional regression testing is necessary as no code behavior has changed.

@nevyangelova nevyangelova requested a review from a team as a code owner March 25, 2026 13:24
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 193c3780-8e5d-4f75-a8b8-2e56a9066705

📥 Commits

Reviewing files that changed from the base of the PR and between eedbb1f and bd20687.

📒 Files selected for processing (1)
  • server/setup_flow.go

📝 Walkthrough

Walkthrough

Updated Jira Cloud OAuth setup instructions in the setup flow to clarify the distinction between Classic and Granular scopes. Modified webhook configuration guidance to recommend selecting only Comment and Issue events, removing references to Attachment events.

Changes

Cohort / File(s) Summary
Jira Cloud Setup Instructions
server/setup_flow.go
Clarified OAuth scopes documentation to distinguish between Classic and Granular scopes in the Atlassian Developer Console. Revised webhook configuration to recommend Comment and Issue events only, removing Attachment event references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update setup flow guidelines' accurately reflects the main change—updating setup instructions in setup_flow.go for Jira OAuth and webhook configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MM-67658-remove-attachment-reference

Comment @coderabbitai help to get the list of available commands and usage tips.

@nevyangelova nevyangelova added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 25, 2026
@ogi-m ogi-m removed the 3: QA Review Requires review by a QA tester label Mar 25, 2026
Copy link
Copy Markdown
Contributor

@avasconcelos114 avasconcelos114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nevyangelova nevyangelova merged commit 737f3cb into master Mar 26, 2026
20 checks passed
@nevyangelova nevyangelova deleted the MM-67658-remove-attachment-reference branch March 26, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2: Dev Review Requires review by a core committer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants