Migrate sidebar_header component to TypeScript #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert sidebar_header.jsx to sidebar_header.tsx with proper TypeScript interfaces - Migrate index.js to index.ts with GlobalState typing - Add missing 'connected' prop that was added to master after original PR - Use getConnected selector for better type safety - Fix interface formatting (proper spacing and semicolons) Addresses feedback from PR #450 and resolves issue #431.
Use 'mattermost-redux/selectors/entities/preferences' instead of 'mattermost-redux/types/preferences' to be consistent with all other TypeScript files in the codebase.
fmartingr
approved these changes
Nov 13, 2025
Member
Author
|
/update-branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate sidebar_header component to TypeScript:
Addresses feedback from PR #450 and resolves issue #431.
Based on a PR submitted by @Willy-Wakam
Ticket Link
fixes #431