Skip to content

Update config files for v1.33 release#983

Merged
agarciamontoro merged 4 commits intomasterfrom
update.config.files
Mar 23, 2026
Merged

Update config files for v1.33 release#983
agarciamontoro merged 4 commits intomasterfrom
update.config.files

Conversation

@agarciamontoro
Copy link
Copy Markdown
Member

@agarciamontoro agarciamontoro commented Mar 20, 2026

Summary

Update the template files used for both the tool release testing and the performance comparison for the upcoming release v1.33, to make sure Playbooks is tested alongside the normal simulations.

Ticket Link

--

@agarciamontoro agarciamontoro requested a review from carlisgg March 20, 2026 15:28
@agarciamontoro agarciamontoro added the 2: Dev Review Requires review by a core committer label Mar 20, 2026
@agarciamontoro
Copy link
Copy Markdown
Member Author

To be cherry-picked into release-1.33.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 06129de2-0615-499b-ba6c-62fa26b70f34

📥 Commits

Reviewing files that changed from the base of the PR and between 0aa049e and 970c050.

📒 Files selected for processing (4)
  • config/deployer.sample.json
  • config/deployer.sample.toml
  • examples/config/perfcomp/json/deployer.json
  • examples/config/release/json/deployer.json
✅ Files skipped from review due to trivial changes (4)
  • examples/config/release/json/deployer.json
  • config/deployer.sample.toml
  • examples/config/perfcomp/json/deployer.json
  • config/deployer.sample.json

📝 Walkthrough

Walkthrough

Updated PostgreSQL dump URLs used by example load tests and added a Mattermost Playbooks v2.8.0 plugin artifact URL to deployer example and sample configuration files.

Changes

Cohort / File(s) Summary
Load test DB dumps
examples/config/perfcomp/json/comparison.json, examples/config/release/json/comparison.json
Replaced DBDumpURL values: .../12M_610_fixed_psql.sql.gz.../12M_11.5.1_psql.sql.gz in LoadTests entries.
Example deployer configs
examples/config/perfcomp/json/deployer.json, examples/config/release/json/deployer.json
Added top-level MattermostPlugins object with playbooks pointing to Playbooks v2.8.0 Linux AMD64 tarball URL.
Sample deployer configs
config/deployer.sample.json, config/deployer.sample.toml
Updated MattermostPlugins.playbooks artifact URL from v2.4.1 → v2.8.0 (Linux AMD64 tarball).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • M-ZubairAhmed
  • DHaussermann

Poem

"I hopped through configs, tidy and spry,
Swapped old dumps for a fresher sky.
A playbook plugin perched on a URL so bold,
v2.8.0 shines in tarball of gold.
— from your busy rabbit, with a hop and a scroll 🐇"

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main changes: updating configuration files for the v1.33 release, which includes Playbooks plugin URLs and database dump URLs across multiple config templates and sample files.
Description check ✅ Passed The description is related to the changeset, explaining that template files for tool release testing and performance comparison are being updated to ensure Playbooks is tested alongside normal simulations for v1.33.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update.config.files

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@carlisgg carlisgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot access the playbooks release. I think this is due to permissions so I guess the deployer can. LGTM.

@agarciamontoro
Copy link
Copy Markdown
Member Author

I cannot access the playbooks release. I think this is due to permissions so I guess the deployer can. LGTM.

Whoops, it was not permissions-related, I had mistaken a dot for a dash! Good catch, thank you for testing!

@agarciamontoro agarciamontoro merged commit c8f189d into master Mar 23, 2026
1 check passed
@agarciamontoro agarciamontoro deleted the update.config.files branch March 23, 2026 09:27
agarciamontoro added a commit that referenced this pull request Mar 23, 2026
* Update dataset in config templates

Use the new dataset containing Playbooks data.

* Add Playbooks plugin v2.8.0 to config templates

* Fix Playbooks URLs in config template files

* Update Playbooks URLs in sample files as well
agarciamontoro added a commit that referenced this pull request Mar 23, 2026
* Update dataset in config templates

Use the new dataset containing Playbooks data.

* Add Playbooks plugin v2.8.0 to config templates

* Fix Playbooks URLs in config template files

* Update Playbooks URLs in sample files as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2: Dev Review Requires review by a core committer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants