Merged
Conversation
…g/config.json when deploying from GitHub release (#980) * Moved configuration accessors to a new file structure under `config/` * Refactor logger tests to use updated config accessors path and mock node modules correctly * Moved LogSettings in browsercontroller.json to manage console and file logging from config.json * Update default logging settings in BrowserLogSettings to enable console logging and set console log level to debug * Add browser controller configuration validation and setup for agent tests - Introduced a new `setupAgentType` function to streamline the setup of agent types in tests. - Updated `TestIsBrowserAgentInstance` and `TestBrowserAgentConfigValidation` to utilize the new setup function. - Enhanced the `createLoadAgentHandler` to validate the `browsercontroller.json` configuration before creating browser agents. - Added logic in the Terraform agent configuration to upload the `browsercontroller.json` to browser agent instances, ensuring valid configurations are used during load tests. * fix test * Fix test with valid config file * Fix typo in comment * Fix typo in docs * Use t.Chdir and t.Setenv instead of os's This takes care of cleanup automatically and marks the test as not suitable for test parallelism. * Use t.TempDir instead of os.MkdirTemp The testing version takes care of cleanup automatically. --------- Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
agarciamontoro
changed the title
lieut-data
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick #980 into release-1.33
Ticket Link
https://mattermost.atlassian.net/browse/MM-67954