Add Docker deployment test workflow #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove CircleCI configuration - Add GitHub Actions workflow for shellcheck 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix variable quoting issues to prevent globbing and word splitting - Fix variable reference typo (POSTGRES_POSTGRES_NEW_VERSION → POSTGRES_NEW_VERSION) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Create GitHub Actions workflow that tests Docker deployment - Test both with and without NGINX configurations - Verify containers run properly and services are accessible - Follow steps from official documentation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove the step that was checking logs for a service named 'app' - Fix CI failure due to 'no such service: app' error 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add generation of self-signed certificates for NGINX - Update log checking to use service names from docker-compose: mattermost, postgres, nginx - Fix HTTPS test with -k flag for self-signed certificate 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Ready for review |
Contributor
Author
|
@jadrales Maybe you have the badwith the review the changes |
vish9812
requested changes
Jul 18, 2025
| cp env.example .env | ||
| sed -i 's/DOMAIN=mm.example.com/DOMAIN=localhost/g' .env | ||
|
|
||
| - name: Start Mattermost without NGINX |
Contributor
Author
There was a problem hiding this comment.
1/5 of the automated testing this PR adds is already a great step forward. I'm hesitant to add another layer of complexity by also testing the nginx setup.
vish9812
approved these changes
Jul 22, 2025
hanzei
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Claude Code
Ticket Link