Skip to content

Use ReactDOM webpack external#10

Merged
hanzei merged 1 commit intomasterfrom
react-dom_webpack-external
Oct 20, 2022
Merged

Use ReactDOM webpack external#10
hanzei merged 1 commit intomasterfrom
react-dom_webpack-external

Conversation

@mickmister
Copy link
Copy Markdown
Contributor

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Sep 21, 2022
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 20, 2022
@hanzei hanzei merged commit 2970cc9 into master Oct 20, 2022
@hanzei hanzei deleted the react-dom_webpack-external branch October 20, 2022 22:58
@mickmister
Copy link
Copy Markdown
Contributor Author

@hanzei I'm thinking we should archive this repo since it seems there are no code additions on top of the original starter template "fork"

@hanzei
Copy link
Copy Markdown
Contributor

hanzei commented Oct 24, 2022

Well, there is #9, which is still up in the air. Maybe we even merge that PR and archive the repo (for now).

@asatkinson Is Twitter an integration that we want to have in 2023?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants