Skip to content

Cherry-pick (#214) into release-2.0#215

Closed
agarciamontoro wants to merge 1 commit intorelease-2.0from
cherry-pick-app-bar-icon
Closed

Cherry-pick (#214) into release-2.0#215
agarciamontoro wants to merge 1 commit intorelease-2.0from
cherry-pick-app-bar-icon

Conversation

@agarciamontoro
Copy link
Copy Markdown
Contributor

Summary

The release-2.0 branch has been created from the v2.0.0 tag. This PR cherry-picks #214 into that branch, so we can release a new v2.1.0 with only this change.

Ticket Link

--

* go get -u golang.org/x/sys

* Fix CI

* Add App Bar icon

* Fix errors found by linter

* Allow arrow functions in eslint's func-style rule

* fix type mismatch at redux Provider

Co-authored-by: Ngoan Tran <ngoan98travinh@gmail.com>
@agarciamontoro agarciamontoro added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 16, 2022
@agarciamontoro agarciamontoro requested a review from jespino as a code owner June 16, 2022 15:14
@DHaussermann
Copy link
Copy Markdown

DHaussermann commented Jun 16, 2022

@agarciamontoro I'm struggling to build this PR branch.
with node 13 I get an error.
image

With node 16 npm fetch goes for a very long time and then ends with...
image

Can you provide a build or some troubleshooting ideas? :)
Maybe the node and npm version you are using to build this or a way to make circle CI build it.

Copy link
Copy Markdown
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question to improve my knowledge.

children: React.ReactNode,
}

export class InjectionProvider extends React.Component<any> {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

@agarciamontoro
Copy link
Copy Markdown
Contributor Author

@DHaussermann, build is also failing on CI. Let me check 🙏

@mickmister
Copy link
Copy Markdown
Contributor

Closing per https://community-daily.mattermost.com/core/pl/cix75ceit3neff7fgacyoo7uth, with the follow up being to release a new version off of master

@mickmister mickmister closed this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants