Feature/25176 bitbucket readme#125
Feature/25176 bitbucket readme#125kat-kan wants to merge 10 commits intomattermost-community:masterfrom
Conversation
* Add badges * Add new outline * Move admin guide to new file in docs directory
* Add outline * Add missing headers
|
Hello @kat-kan, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
|
/check-cla |
|
|
|
@mickmister - Looking forward to your technical review of this PR -- particularly the image updates. |
|
I am also looking forward to the review :) |
hanzei
left a comment
hanzei
left a comment
There was a problem hiding this comment.
The overall direction looks good 👍
There are still a couple of times that need work before we can merge the PR.
mickmister
left a comment
mickmister
left a comment
There was a problem hiding this comment.
Thanks for the contribution @kat-kan 🎉
LGTM, given hanzei's requests are fulfilled. Thanks!
|
@hanzei - I believe the only check remaining is to ensure that the image assets are in the correct location. |
|
@cwarnermm I believe they are but builds are failing after moving images because they expect specific location. I am waiting for confirmation that I should revert changes. |
…les with new directory" This reverts commit 9d24874.
|
I reverted the changes related to images, every suggestion was introduced |
|
@cwarnermm as we are still waiting for @hanzei to accept the changes, can you please consider adding "hacktoberfest-accepted" label? The review period in Hacktoberfest ends tomorrow and PR has to be either merged or have the label to be even considered. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 15.03% 15.03%
=======================================
Files 13 13
Lines 2301 2301
=======================================
Hits 346 346
Misses 1936 1936
Partials 19 19 ☔ View full report in Codecov by Sentry. |
|
@mickmister The broken CI is unrelated to the PR. What are the next steps to getting it fixed? |
|
/update-branch |
@cwarnermm I'm not sure there are any image updates in the PR? |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
mickmister
left a comment
mickmister
left a comment
There was a problem hiding this comment.
Thanks @kat-kan! I have just one suggestion to check-in an image that is currently pointing to https://user-images.githubusercontent.com. This was already pointing to that so the change is optional for this PR, though since we are cleaning up the README I think why not.
Your work LGTM 👍 Thanks so much!
| - **Slash commands:** Interact with the Bitbucket plugin using the `/bitbucket` slash command. | ||
|
|
||
| ### Onboard users | ||
|  |
There was a problem hiding this comment.
Can we instead have the image committed to this repo?
6 participants
Summary
This PR organizes README.md, admin-guide.md and project assets in a way described here mattermost/mattermost#25176
I have
Ticket Link
Fixes mattermost/mattermost#25176
https://mattermost.atlassian.net/browse/MM-55077