Skip to content

Draft: Start supporting integration tests#4

Closed
selfhoster1312 wants to merge 1671 commits intomatterbridge-org:masterfrom
selfhoster1312:test-xmpp
Closed

Draft: Start supporting integration tests#4
selfhoster1312 wants to merge 1671 commits intomatterbridge-org:masterfrom
selfhoster1312:test-xmpp

Conversation

@selfhoster1312
Copy link
Copy Markdown
Collaborator

@selfhoster1312 selfhoster1312 commented Sep 11, 2025

This is very early work. Definitely not ready for review, but i thought i'd get it out here to show what i'm working on.

The idea is each protocol can have its own integration tests to verify that messages actually come through a remote server. This is in my opinion more useful than unit tests, and would allow in the future to actually test the feature matrix matterbridge-org/community#7

Hopefully the test passes here?! It passes locally (with go/prosody/prosody-modules installed) when running tests/test.sh xmpp outgoing-message. Here's the output it produces for the moment:

[xmpp] Starting setup.sh
[xmpp] Started setup.sh successfully
[xmpp] Starting matterbridge
[xmpp] Started matterbridge successfully
[xmpp] Successful setup steps… Continuing.
[xmpp] Protocol client ready to start test.
[xmpp] matterbrige took more than 5 seconds to quit. See tests/xmpp/matterbridge.log
[xmpp] setup.sh took more than 5 seconds to quit. See tests/xmpp/setup.log
OK outgoing-message

Avinash Reddy and others added 30 commits May 21, 2021 22:50
@42wim
Handle document messages (whatsapp) (42wim#1475)
a189298 
* [Whatsapp] Add DocumentMessage handler

* Fix typo

Thanks @42wim :)

Co-authored-by: Wim <wim@42.be>

Co-authored-by: Wim <wim@42.be>
@42wim
Rename .jpe files to .jpg Fixes 42wim#1463 (whatsapp) (42wim#1485)
b9fb361
Fix crash on encountering VideoMessage (whatsapp) (42wim#1483)
ec6ae34 
* [whatsapp] fix crash on encountering VideoMessage

* Update handlers.go

* gofmt
@chrisbobbe
Delete now-unused img/slack-setup-*.png files (42wim#1491)
4b4b2d7
Make DocumentMessage handler use FileName attribute (whatsapp) (42wim…
4fcad8e 
…#1488)

* [whatsapp] make DocumentMessage handler use FileName attribute.

referenced: https://github.com/Rhymen/go-whatsapp/blob/master/message.go#L582

* fix lint
@gary-kim @42wim
Support sending file URLs (nctalk) (42wim#1489)
efec01a 
* nctalk: support sending file URLs

Signed-off-by: Gary Kim <gary@garykim.dev>

* nctalk: reduce nesting

Co-authored-by: Wim <wim@42.be>
Signed-off-by: Gary Kim <gary@garykim.dev>

Co-authored-by: Wim <wim@42.be>
@42wim
Add a MessageClipped option to set your own clipped message. Closes 4…
c861374 
…2wim#1359 (42wim#1487)
@gary-kim
Fix content body issue for redactions (matrix) (42wim#1496)
766f355 
Signed-off-by: Gary Kim <gary@garykim.dev>
@42wim
Update vendor (42wim#1498)
4091b6f
@42wim
Update irc references (42wim#1499)
c7897cc
@gary-kim
Add support for message deletion (nctalk) (42wim#1492)
1d50da4 
* nctalk: add message deletion support

Signed-off-by: Gary Kim <gary@garykim.dev>

* nctalk: seperate out deletion and sending logic

Signed-off-by: Gary Kim <gary@garykim.dev>

* nctalk: update library to v0.2.0

Signed-off-by: Gary Kim <gary@garykim.dev>

* Rename functions to be clearer

Signed-off-by: Gary Kim <gary@garykim.dev>

* Update to go-nc-talk v0.2.1

Signed-off-by: Gary Kim <gary@garykim.dev>

* Update to go-nc-talk v0.2.2

Signed-off-by: Gary Kim <gary@garykim.dev>

* Make deletions easier to debug

Signed-off-by: Gary Kim <gary@garykim.dev>
@42wim
Release v1.22.2 (42wim#1504)
641ed18
@42wim
Bump version
6a12f9f
@nathanaelhoun
Update Rhymen/go-whatsapp module to latest master (2b8a3e9b8aa2) (42w…
dedc1c4 
…im#1518)
@42wim
Update dependencies (42wim#1521)
fb5a842
@42wim
Release v1.22.3 (42wim#1522)
e45bbe4 
* Release v1.22.3
@42wim
Bump version
f364984
@gary-kim
Add support for separate display name (nctalk) (42wim#1506)
a79e632 
Signed-off-by: Gary Kim <gary@garykim.dev>
@42wim
Update matterbridge.toml.sample
17c2d1f
@42wim
Update .goreleaser.yml
66b6f97
@KidA001
Use correct URL for Mediaserver Setup (42wim#1550)
d93ab04
@minecraftchest1
Add link to service files wiki page (42wim#1545)
761c0b7 
Added Systemd section to README.md. Added Systemd to table of contents.
@tytan652
Fix XMPP parseNick function (42wim#1547)
da4dcec
@KidA001
Add space before file upload comment (slack) (42wim#1554)
13bbeea
@42wim
Update matterbridge/go-xmpp vendor (42wim#1559)
9efcc41
@tytan652
Add support for anonymous connection (xmpp) (42wim#1548)
1f365c7
@42wim
Update vendor (42wim#1560)
44f3e25
@powerjungle
Remove newline character in bridge multiline messages (mumble) (42wim…
86151da 
…#1572)
@42wim
Update github actions to go1.17 and increase deadline (42wim#1573)
400ecfb
@42wim
Disable errorlint,gci and nlreturn
d4195de
@selfhoster1312 selfhoster1312 force-pushed the test-xmpp branch 19 times, most recently from dcea884 to e26b6a4 Compare September 12, 2025 09:10
@selfhoster1312
Copy link
Copy Markdown
Collaborator Author

selfhoster1312 commented Sep 12, 2025

So the pipeline passed for the first time on Github (was working locally since yesterday) but there's still caveats:

  • only XMPP tests are implemented
  • even then, only outgoing-message test is implemented (bridge -> xmpp)
  • some documentation is missing in tests/README.md
  • there's currently no mechanism to orchestrate several tests in a row:
    • respect a test list in a given order: what should be the authoritative source for the list?
    • should switching tests be "automated" inside the test scripts? or should it be triggered from tests/test.sh eg. with writing to a file and sending SIGUSR1 to tests
    • currently it's hardcoded that $PROTOCOL client should be ready before API client is started, but some tests (eg. incoming-message) would be the other way around, we should check that both are ready then send a signal to trigger the test
  • what are the valid test output states we'd like to represent? probably something like OK, FAIL, SKIP (unimplemented), in which case FAIL would fail the entire job, whereas SKIP would be success-like
  • how to store/render test output for input in the protocol features matrix? Document supported features per bridge community#7

poVoq pushed a commit to poVoq/matterbridge that referenced this pull request Oct 5, 2025
@antonizoon
Merge pull request matterbridge-org#4 from 42wim/dependabot/go_module…
5123249 
…s/golang.org/x/crypto-0.31.0

Bump golang.org/x/crypto from 0.25.0 to 0.31.0
@selfhoster1312 selfhoster1312 mentioned this pull request Oct 10, 2025
Merged
This was referenced Oct 24, 2025
Closed
Open
@selfhoster1312
Copy link
Copy Markdown
Collaborator Author

selfhoster1312 commented Oct 24, 2025

Closing in favor of #8

poVoq pushed a commit that referenced this pull request Apr 11, 2026
@SwirlyStone5877 @poVoq
squash commits, see #195
8441760 
 This is a combination of 4 commits.

 This is the 1st commit message:
ah yes, change the changelog

 This is the commit message #2:
this is a good word i think

 This is the commit message #3:
run go fmt because ci error

 This is the commit message #4:
maybe?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.