Update Github Actions in CI and check go fmt

.github/workflows/development.yml

@@ -8,59 +8,68 @@ on:
     paths-ignore:
       - 'docs/**'
       - 'README.md'
+permissions:
+  contents: read
+  pull-requests: read
 jobs:
   lint:
     name: golangci-lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v5
+      - uses: actions/setup-go@v6
         with:
-          fetch-depth: 20
-      - name: Run golangci-lint
-        uses: golangci/golangci-lint-action@v3
+          go-version: 1.22.x
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v8
         with:
-          version: latest
-          args: "-v --new-from-rev HEAD~5 --timeout=5m"
-  test-build-upload:
+          version: v2.1
+          # Only compare with previous commit when pushing,
+          # and with base branch when in PR.
+          only-new-issues: true
+  test:
     strategy:
       matrix:
-        go-version: [1.22.x]
-        platform: [ubuntu-latest]
-    runs-on: ${{ matrix.platform }}
+        # Test on latest release and v1.22
+        go-version: [1.22.x, stable]
+    runs-on: ubuntu-latest
+    steps:
+      - name: Install Go
+        uses: actions/setup-go@v6
+        with:
+          go-version: ${{ matrix.go-version }}
+      - name: Checkout code
+        uses: actions/checkout@v5
+      - name: go fmt ./... (go version ${{ matrix.go-version }})
+        run: test -z "$(go fmt ./...)"
+      - name: go test ./... -mod=vendor (go version ${{ matrix.go-version }})
+        run: go test ./... -mod=vendor
+  build-upload:
+    # Uploading artifacts only if lint/test succeeded
+    needs: [ "lint", "test" ]
+    strategy:
+      matrix:
+        arch: [amd64]
+        platform:
+          - name: linux
+            goos: linux
+          - name: windows
+            goos: windows
+          - name: mac
+            goos: darwin
+    runs-on: ubuntu-latest
     steps:
-    - name: Install Go
-      uses: actions/setup-go@v3
-      with:
-        go-version: ${{ matrix.go-version }}
-        stable: false
-    - name: Checkout code
-      uses: actions/checkout@v3
-      with:
-          fetch-depth: 0
-    - name: Test
-      run: go test ./... -mod=vendor
-    - name: Build
-      run: |
-        mkdir -p output/{win,lin,arm,mac}
-        VERSION=$(git describe --tags)
-        CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-s -X github.com/42wim/matterbridge/version.GitHash=$(git log --pretty=format:'%h' -n 1)" -o output/lin/matterbridge-$VERSION-linux-amd64
-        CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -ldflags "-s -X github.com/42wim/matterbridge/version.GitHash=$(git log --pretty=format:'%h' -n 1)" -o output/win/matterbridge-$VERSION-windows-amd64.exe
-        CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -ldflags "-s -X github.com/42wim/matterbridge/version.GitHash=$(git log --pretty=format:'%h' -n 1)" -o output/mac/matterbridge-$VERSION-darwin-amd64
-    - name: Upload linux 64-bit
-      if: startsWith(matrix.go-version,'1.22')
-      uses: actions/upload-artifact@v3
-      with:
-        name: matterbridge-linux-64bit
-        path: output/lin
-    - name: Upload windows 64-bit
-      if: startsWith(matrix.go-version,'1.22')
-      uses: actions/upload-artifact@v3
-      with:
-        name: matterbridge-windows-64bit
-        path: output/win
-    - name: Upload darwin 64-bit
-      if: startsWith(matrix.go-version,'1.22')
-      uses: actions/upload-artifact@v3
-      with:
-        name: matterbridge-darwin-64bit
-        path: output/mac
+      - name: Install Go
+        uses: actions/setup-go@v6
+        with:
+          go-version: stable
+      - name: Checkout code
+        uses: actions/checkout@v5
+      - name: Build/upload matterbridge for ${{ matrix.platform.goos }}-${{ matrix.arch }}
+        run: |
+          CGO_ENABLED=0 GOOS=${{ matrix.platform.goos }} GOARCH=${{ matrix.arch }} go build -ldflags "-s -X github.com/42wim/matterbridge/version.GitHash=$(git log --pretty=format:'%h' -n 1)" -o matterbridge
+      - name: Upload matterbridge-${{ matrix.name }}-${{ matrix.arch }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: matterbridge-${{ matrix.platform.goos }}-${{ matrix.arch }}
+          path: matterbridge